Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling out PDF Markup into it's own chunk & allowing Sewing Marks on only some folios & some bug fixes #115

Merged
merged 3 commits into from
May 4, 2024

Conversation

sithel
Copy link
Collaborator

@sithel sithel commented Apr 30, 2024

Building atop my spine line PR #109

  • This fixes some bugs (sewing marks getting stuck 'on', the page positioning not getting persisted via settings)
  • Carves out PDF Markup section
  • Auto-expands (or collapses) sewing markup section on page load based on enabled-ness
  • Supporting the option to only have sewing marks in some of the places
Screen Shot 2024-04-29 at 10 12 11 PM

Copy link

github-actions bot commented Apr 30, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-05-04 23:23 UTC

@momijizukamori momijizukamori merged commit 4d17814 into six_sig_spine_marks May 4, 2024
3 checks passed
momijizukamori pushed a commit that referenced this pull request May 7, 2024
* initial stab & functionality of spine marks

* cleaning up things...

* fucking ;s....

* dropping unneeded console.log

* prettier fixes

* fix typos

* ran that prettier

* Pulling out PDF Markup into it's own chunk & allowing Sewing Marks on only some folios & some bug fixes (#115)

* now with a PDF Markup section + sewing marks on only some of the folios

* bumping version #

* turning off preview hack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants