Improve file naming and pathing #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acestronautical
requested review from
momijizukamori,
sithel and
cass-kazumori
as code owners
|
acestronautical
force-pushed
the
filenaming
branch
from
356a596 to
cdc8748
Compare
acestronautical
force-pushed
the
filenaming
branch
4 times, most recently
from
633e1de to
d0eff58
Compare
Original pdf name will now correctly regex replace. The previous regex was lacking the g flag causing it to not remove the pdf extension if a space or comma was present. File name conversion now replaces space, commas, and hypens to underscores. Signature files will be placed into a signatures/ folder.
acestronautical
force-pushed
the
filenaming
branch
from
d0eff58 to
06a0b52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original pdf name will now correctly regex replace. The previous regex was lacking the g flag causing it to not remove the pdf extension if a space or comma was present.
File name conversion now replaces space, commas, and hypens to underscores.
Signature files will be placed into a signatures/ folder.
NEW:
OLD:
