Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Name generated PDFs based on original PDF #93

Closed
acestronautical opened this issue Feb 10, 2024 · 2 comments
Closed

Feature: Name generated PDFs based on original PDF #93

acestronautical opened this issue Feb 10, 2024 · 2 comments

Comments

@acestronautical
Copy link
Collaborator

Currently we generate files named like "aggregate.pdf" it would be nice if the downloaded files were named based on the original PDF name. So like "china and the mongols.pdf" becomes "china and the mongols - typeset - 4signature -duplex - aggregate.pdf" or something similar.

@acestronautical acestronautical changed the title Name generated PDFs based on original PDF Feature: Name generated PDFs based on original PDF Feb 10, 2024
@sithel
Copy link
Collaborator

sithel commented Feb 10, 2024

the name for a long while was trying to hold some of the settings info -- now with @cass-kazumori 's work, that is no longer needed. What is the scheme you're proposing exactly?

We have the ZIP file name
We have the file names within the ZIP file

I agree that the original file name should be repeated through all files.
Don't have the bandwidth to propose something now but would appreciate seeing a specific schema being proposed before PR work begins (but 👍 to the work)

@acestronautical
Copy link
Collaborator Author

I am proposing as shown in: #104

Sorry it was easier to just implement than think about.
Let me know if the schema in my PR looks good, am willing to change to whatever folks think is best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants