Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete invalid archives to prevent failing file copies later on #588

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from
Open

Delete invalid archives to prevent failing file copies later on #588

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Menlo-Legacy/lib/Menlo/CLI/Compat.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1449,7 +1449,11 @@ sub fetch_module {
$dist->{local_path} = File::Spec->rel2abs($name);

my $dir = $self->unpack($file, $uri, $dist);
next unless $dir; # unpack failed
# unpack failed
unless ($dir) {
unlink $file; # make sure it's not fooling any following local file copy
next;
}

if (my $save = $self->{save_dists}) {
# Only distros retrieved from CPAN have a pathname set
Expand Down