Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete invalid archives to prevent failing file copies later on #588

Open
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

maxhq
Copy link

@maxhq maxhq commented Dec 13, 2018

This should fix #587

@stuartskelton
Copy link

This works for me.

@stuartskelton
Copy link

Looking into it a little more, the mirroring could be fixed a little more too,

EG,

In HTTP::Tinyish::Curl (which is the backend I am using)

We could ask for a file not to be saved, see https://stackoverflow.com/a/90009.

    my($output, $error);
    eval {
        run3 [
            $curl,
            $self->build_options($url, $opts),
            '-fO', # do not save a fail if there is a failure
            '-z', $file,
            '-o', $file,
            '--dump-header', $temp,
            '--remote-time',
            $url,
        ], \undef, \$output, \$error;
    };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation fails if specifying file system DarkPAN mirror after official one
2 participants