feat(frontend,mfm): allow RGBA8888 for fg.color and bg.color #12496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #12496 +/- ##
============================================
- Coverage 66.21% 20.17% -46.05%
============================================
Files 990 698 -292
Lines 117137 97638 -19499
Branches 4489 1014 -3475
============================================
- Hits 77568 19699 -57869
- Misses 39538 77419 +37881
- Partials 31 520 +489 ☔ View full report in Codecov by Sentry. |
syuilo
reviewed
Nov 29, 2023
packages/frontend/src/components/global/MkMisskeyFlavoredMarkdown.ts
Outdated
Show resolved
Hide resolved
packages/frontend/src/components/global/MkMisskeyFlavoredMarkdown.ts
Outdated
Show resolved
Hide resolved
|
rebased onto latest master |
|
bump |
|
@syuilo @acid-chicken コンフリクトを解消したらマージできる状態にありますか？ |
apply diff from review
apply diff from review
|
なんか謎にrebaseが走ったような気がしますがおそらくこれでマージできる状態になるはずです。 |
kakkokari-gtyih
approved these changes
Jan 25, 2024
|
(…🥲) |
# Conflicts: # packages/frontend/src/components/global/MkMisskeyFlavoredMarkdown.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
close #10683
Why
issueに記載のため省略
Additional info (optional)
5桁の入力を受け付けない正規表現になっていますが、現行の実装では白色として描画されるため事実上breaking changeにはならないと考えています。
Checklist