-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): 8桁RRGGBBAAのサポート #87
Conversation
|
upstreamに投げて欲しさある。連合結果があんま良くなくなると思うし |
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -37027,36 +37027,7 @@
"nullable": true
},
"mutedWords": {
- "type": "array",
- "items": {
- "oneOf": [
- {
- "type": "array",
- "items": {
- "type": "string"
- }
- },
- {
- "type": "string"
- }
- ]
- }
- },
- "hardMutedWords": {
- "type": "array",
- "items": {
- "oneOf": [
- {
- "type": "array",
- "items": {
- "type": "string"
- }
- },
- {
- "type": "string"
- }
- ]
- }
+ "type": "array"
},
"mutedInstances": {
"type": "array",
@@ -59802,21 +59773,6 @@
}
}
},
- "hardMutedWords": {
- "type": "array",
- "nullable": false,
- "optional": false,
- "items": {
- "type": "array",
- "nullable": false,
- "optional": false,
- "items": {
- "type": "string",
- "nullable": false,
- "optional": false
- }
- }
- },
"mutedInstances": {
"type": "array",
"nullable": true,
@@ -59886,7 +59842,6 @@
"hasPendingReceivedFollowRequest",
"unreadNotificationsCount",
"mutedWords",
- "hardMutedWords",
"mutedInstances",
"notificationRecieveConfig",
"emailNotificationTypes" |
とりあえず…これはこのままで大丈夫なのでしょうか? (3文字から8文字までの全てのパターンで一致することを確認済みです) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issueやPRでの説明内容とコード内容が一致しておらず、確認が行われるまでこのPRを承認することが出来ません。
(また、連合の観点から本家リポジトリにPRすることを推奨します)
レビューしていただきありがとうございます。修正済みのコミットを misskey-dev#12496 として提出したのでcloseします。 |
What
close #86
Why
issue通りの内容のため省略
Additional info (optional)
Checklist