Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): 8桁RRGGBBAAのサポート #87

Closed
wants to merge 1 commit into from
Closed

feat(frontend): 8桁RRGGBBAAのサポート #87

wants to merge 1 commit into from

Conversation

KisaragiEffective
Copy link

What

close #86

Why

issue通りの内容のため省略

Additional info (optional)

  • 5桁の色入力を受け付けなくなりますが現行バージョンでは色がつかないため実質breaking changeではありません

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@Sayamame-beans
Copy link

/^[0-9a-f]{3,4}([0-9a-f]{2}|[0-9a-f]{4})?$/だと、3文字から8文字までの全てのパターンに一致しませんか?
3: 3+0
4: 4+0
5: 3+2
6: 4+2
7: 3+4
8: 4+4

@anatawa12
Copy link
Collaborator

upstreamに投げて欲しさある。連合結果があんま良くなくなると思うし

Copy link

このPRによるapi.jsonの差分

差分はこちら
--- base
+++ head
@@ -37027,36 +37027,7 @@
                     "nullable": true
                   },
                   "mutedWords": {
-                    "type": "array",
-                    "items": {
-                      "oneOf": [
-                        {
-                          "type": "array",
-                          "items": {
-                            "type": "string"
-                          }
-                        },
-                        {
-                          "type": "string"
-                        }
-                      ]
-                    }
-                  },
-                  "hardMutedWords": {
-                    "type": "array",
-                    "items": {
-                      "oneOf": [
-                        {
-                          "type": "array",
-                          "items": {
-                            "type": "string"
-                          }
-                        },
-                        {
-                          "type": "string"
-                        }
-                      ]
-                    }
+                    "type": "array"
                   },
                   "mutedInstances": {
                     "type": "array",
@@ -59802,21 +59773,6 @@
               }
             }
           },
-          "hardMutedWords": {
-            "type": "array",
-            "nullable": false,
-            "optional": false,
-            "items": {
-              "type": "array",
-              "nullable": false,
-              "optional": false,
-              "items": {
-                "type": "string",
-                "nullable": false,
-                "optional": false
-              }
-            }
-          },
           "mutedInstances": {
             "type": "array",
             "nullable": true,
@@ -59886,7 +59842,6 @@
           "hasPendingReceivedFollowRequest",
           "unreadNotificationsCount",
           "mutedWords",
-          "hardMutedWords",
           "mutedInstances",
           "notificationRecieveConfig",
           "emailNotificationTypes"

Get diff files from Workflow Page

@Sayamame-beans
Copy link

/^[0-9a-f]{3,4}([0-9a-f]{2}|[0-9a-f]{4})?$/だと、3文字から8文字までの全てのパターンに一致しませんか? 3: 3+0 4: 4+0 5: 3+2 6: 4+2 7: 3+4 8: 4+4

とりあえず…これはこのままで大丈夫なのでしょうか? (3文字から8文字までの全てのパターンで一致することを確認済みです)

@Sayamame-beans Sayamame-beans self-requested a review November 27, 2023 11:39
Copy link

@Sayamame-beans Sayamame-beans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issueやPRでの説明内容とコード内容が一致しておらず、確認が行われるまでこのPRを承認することが出来ません。
(また、連合の観点から本家リポジトリにPRすることを推奨します)

@KisaragiEffective
Copy link
Author

レビューしていただきありがとうございます。修正済みのコミットを misskey-dev#12496 として提出したのでcloseします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fg.colorとbg.colorを8桁RRGGBBAAに対応させたい
3 participants