Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): クライアント設定から13.7.0で削除されたチャット機能に関するサウンド設定を削除 #11962

Conversation

camilla-ett
Copy link
Contributor

What

#11912
これからlocalesの修正を除いた版のPR

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (5edc885) 78.93% compared to head (3518058) 78.82%.
Report is 22 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #11962      +/-   ##
===========================================
- Coverage    78.93%   78.82%   -0.12%     
===========================================
  Files          928      178     -750     
  Lines        99069    23305   -75764     
  Branches      7888      511    -7377     
===========================================
- Hits         78202    18369   -59833     
+ Misses       20867     4936   -15931     
Files Coverage Δ
packages/frontend/src/scripts/sound.ts 81.48% <ø> (-1.04%) ⬇️

... and 758 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syuilo
Copy link
Member

syuilo commented Oct 4, 2023

https://github.com/misskey-dev/misskey/pull/11912をマージしました👍

@syuilo syuilo closed this Oct 4, 2023
@camilla-ett camilla-ett deleted the remove_clinet_setting_sound_chat_exclude_locales branch October 4, 2023 20:17
@camilla-ett
Copy link
Contributor Author

お忙しい中対応ありがとうございます🙏🙏🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants