fix(frontend): クライアント設定から13.7.0で削除されたチャット機能に関するサウンド設定を削除 #11912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #11912 +/- ##
===========================================
- Coverage 78.93% 78.67% -0.27%
===========================================
Files 928 176 -752
Lines 99069 23144 -75925
Branches 7888 511 -7377
===========================================
- Hits 78202 18208 -59994
+ Misses 20867 4936 -15931
☔ View full report in Codecov by Sentry. |
camilla-ett
force-pushed
the
remove_clinet_setting_sound_chat
branch
from
9cbe93d to
fb55d88
Compare
camilla-ett
changed the title
camilla-ett
force-pushed
the
remove_clinet_setting_sound_chat
branch
from
b162b35 to
ada99ec
Compare
acid-chicken
approved these changes
Sep 28, 2023
tai-cha
approved these changes
Sep 29, 2023
|
チャット機能が復活する可能性もないことはないからUI上から設定項目を消すだけ(ローカリゼーションや設定自体は残す)で良さそうと思ったけどどうだろ |
DMノートをチャット風UIで表示する機能が実装される可能性は大いにある |
|
復活させるときにRevertすればいい説もあるといえばありそう |
だとすれば、おそらくそれはチャットでは無く、今ある機能の名前で言うとダイレクトノートなので、 |
|
locales を残す場合は、 45f15bd のコミットだけchery-pickすれば良いので、どちらでも……！ |
camilla-ett
force-pushed
the
remove_clinet_setting_sound_chat
branch
from
ada99ec to
2bdeb81
Compare
5 tasks
|
#11962 |
|
🙏 |
kanarikanaru
pushed a commit
to kanarikanaru/misskey
that referenced
this pull request
Oct 12, 2023
…#11912) * fix(frontend): クライアント設定から13.7.0で削除されたチャット機能に関するサウンド設定を削除 * fix(frontend): 各localesからsfx/chat sfx/chatbgを削除
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
クライアント設定->サウンド から以下の２項目を削除した
before
after
Why
チャット機能は 13.7.0 で削除されており （https://misskey-hub.net/docs/releases.html#_13-7-0 ）
サウンド設定だけがクライアント設定に残っていたため、削除した。
Additional info (optional)
Checklist