Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Show submitted referrals" #669

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Revert "Show submitted referrals" #669

merged 1 commit into from
Oct 9, 2023

Conversation

libuk
Copy link
Contributor

@libuk libuk commented Oct 9, 2023

Reverts #663

The e2e test for booking a referral is failing. Reverting to make sure we're not blocked to release to other regions.

@libuk libuk marked this pull request as ready for review October 9, 2023 08:43
@libuk libuk requested a review from tahb October 9, 2023 08:43
@libuk
Copy link
Contributor Author

libuk commented Oct 9, 2023

A referrer can view their own application that they've submitted

@libuk
Copy link
Contributor Author

libuk commented Oct 9, 2023

CPPs want to see their submitted referrals

@tahb
Copy link
Contributor

tahb commented Oct 9, 2023 •
edited
Loading

In case it's a useful reference I think the failure output is this one?

  1) Apply for and book a Temporary Accommodation bedspace
       Creating an application:
     AssertionError: Timed out retrying after 4000ms: Expected to find content: '30 Aug 23' within the element: <td.govuk-table__cell> but never did.
      at Context.eval (https://temporary-accommodation-dev.hmpps.service.justice.gov.uk/__cypress/****s?p=e2e/****s/apply-and-place.feature:44014:34)

@libuk libuk merged commit 800e4c5 into main Oct 9, 2023
3 checks passed
@libuk libuk deleted the revert-663-feature/1348-show-submitted-referrals branch October 9, 2023 09:06
@libuk libuk mentioned this pull request Oct 9, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tahb tahb tahb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@libuk @tahb