Show submitted referrals to CPPs #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libuk
force-pushed
the
feature/1348-show-submitted-referrals-to-referrers
branch
from
4fdbab9 to
9c1c0c1
Compare
In a previous change[1], we hid submitted referrals due to it causing confusion for users. We were linking the user back to the check your answers page which gave the impression that the application wasn't submitted. We are now going to link these referrals to a new page which shows the full submitted referral. This commit reinstates the submitted referrals tab and renders a list of submitted referrals. [1] #516
This commit puts in place the plumbing for the new full submitted application page.
Now that we have the full submitted application page, we can link from the referrals table to our new page.
libuk
force-pushed
the
feature/1348-show-submitted-referrals-to-referrers
branch
2 times, most recently
from
4f34619 to
8d3ba0e
Compare
libuk
changed the title
libuk
changed the title
libuk
force-pushed
the
feature/1348-show-submitted-referrals-to-referrers
branch
from
8d3ba0e to
1963c64
Compare
In a previous commit[1], the shape of application data changed and as result, we stopped showing the arrival date. This is due to the logic relying on the 'basic-information' key which was removed. Fixing this requires API changes to return the arrivalDate on submitted applications, and due to the limited dev days left on CAS3, this isn't possible right now. As we have added the tab for submitted referrals back, we are changing the column to instead show the date submitted and hide the column for in progress referrals. In our e2e test for checking the submitted application, we add a flag for checking the submittedAt date. This is because it is set by the API so it is difficult to assert in our e2e test. When running our integration test however, we have control over which applications appear so we still assert in that context. [1] ec0a2b8
As this is no longer being referenced, it's safe to delete.
libuk
force-pushed
the
feature/1348-show-submitted-referrals-to-referrers
branch
from
1963c64 to
213ddbc
Compare
pezholio
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In a previous change[1], we hid submitted referrals due to it causing
confusion for users. We were linking the user back to the check your
answers page which gave the impression that the application wasn't
submitted.
We are now going to link these referrals to a new page which shows the
full submitted referral.
[1]
#516
Changes in this PR
Screenshots of UI changes
Before
After
Release checklist
Release process documentation.
Pre-merge checklist
(eg. CAS API)
Post-merge checklist
release to test
release to preprod
release to prod