Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show submitted referrals #663

Merged
merged 6 commits into from
Oct 5, 2023
Merged

Conversation

libuk
Copy link
Contributor

@libuk libuk commented Oct 3, 2023

Context

In a previous change[1], we hid submitted referrals due to it causing
confusion for users. We were linking the user back to the check your
answers page which gave the impression that the application wasn't
submitted.

We are now going to link these referrals to a new page which shows the
full submitted referral.

[1]
#516

Changes in this PR

  • Reinstate the submitted referrals tab
  • Introduce full submitted referral page

Screenshots of UI changes

Before

Screenshot 2023-10-05 at 12 10 55

After

Screenshot 2023-10-05 at 12 47 48
Screenshot 2023-10-05 at 12 03 16
Screenshot 2023-10-05 at 12 03 30

Release checklist

Release process documentation.

Pre-merge checklist

  • Are any changes required to dependent services for this change to work?
    (eg. CAS API)
  • Have they been released to production already?

Post-merge checklist

@libuk libuk force-pushed the feature/1348-show-submitted-referrals branch 10 times, most recently from 72d4c9c to 7b0bece Compare October 5, 2023 11:40
@libuk libuk changed the title Feature/1348 show submitted referrals Show submitted referrals Oct 5, 2023
libuk added 6 commits October 5, 2023 12:54
In a previous change[1], we hid submitted referrals due to it causing
confusion for users. We were linking the user back to the check your
answers page which gave the impression that the application wasn't
submitted.

We are now going to link these referrals to a new page which shows the
full submitted referral.

This commit reinstates the submitted referrals tab and renders a list of
submitted referrals.

[1]
#516
This commit puts in place the plumbing for the new full submitted
application page.
Now that we have the full submitted application page, we can link from
the referrals table to our new page.
In a previous commit[1], the shape of application data changed and as
result, we stopped showing the arrival date. This is due to the logic
relying on the 'basic-information' key which was removed.

Fixing this requires API changes to return the arrivalDate on submitted
applications, and due to the limited dev days left on CAS3, this isn't
possible right now.

As we have added the tab for submitted referrals back, we are changing
the column to instead show the date submitted and hide the column for in
progress referrals.

[1]
ec0a2b8
As this is no longer being referenced, it's safe to delete.
@libuk libuk force-pushed the feature/1348-show-submitted-referrals branch from 7b0bece to f18904e Compare October 5, 2023 11:54
@libuk libuk marked this pull request as ready for review October 5, 2023 13:07
@libuk
Copy link
Contributor Author

libuk commented Oct 5, 2023

@libuk
Copy link
Contributor Author

libuk commented Oct 5, 2023

@libuk libuk requested review from tahb and selina-dxw October 5, 2023 14:39
Copy link
Contributor

@pezholio pezholio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@libuk libuk merged commit 0945c32 into main Oct 5, 2023
3 checks passed
@libuk libuk deleted the feature/1348-show-submitted-referrals branch October 5, 2023 15:39
@libuk libuk restored the feature/1348-show-submitted-referrals branch October 9, 2023 09:56
@selina-dxw
Copy link

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants