Pin Ubuntu version in github action to 22.04 #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This week, Github changed the `ubuntu-latest` to Ubuntu 24. This broken our linting action where shellcheck keep on following with the following error: ``` Run npm run shellcheck > [email protected] shellcheck > npx shellcheck ./script/**/*[^utils] ./script/utils/** [INFO ] ShellCheck binary not found or invalid, downloading to '/home/runner/work/hmpps-temporary-accommodation-ui/hmpps-temporary-accommodation-ui/node_modules/shellcheck/bin/shellcheck' [INFO ] Downloading 'https://github.com/vscode-shellcheck/shellcheck-binaries/releases/download/v0.10.0/shellcheck-v0.10.0.linux.x86_64.tar.gz' to '/tmp/uNDjpK/shellcheck.download' [INFO ] Extracting '/tmp/uNDjpK/shellcheck.download' to '/tmp/uNDjpK' [INFO ] Copying '/tmp/uNDjpK/shellcheck' to '/home/runner/work/hmpps-temporary-accommodation-ui/hmpps-temporary-accommodation-ui/node_modules/shellcheck/bin/shellcheck' [INFO ] ShellCheck binary successfully downloaded to '/home/runner/work/hmpps-temporary-accommodation-ui/hmpps-temporary-accommodation-ui/node_modules/shellcheck/bin/shellcheck' ./script/**/*[^utils]: ./script/**/*[^utils]: openBinaryFile: does not exist (No such file or directory) Error: Process completed with exit code 2. ``` See: https://github.com/ministryofjustice/hmpps-temporary-accommodation-ui/actions/runs/12350577855/job/34517811023 We have seen this error before and it was an issue with github action runners. I noticed that the ubuntu version has been bumped and its most likely why shellcheck has broken again. All the jobs also had the following warning from Github: ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see actions/runner-images#10636
aliuk2012
force-pushed
the
pin-ubuntu-version-in-github-workflow
branch
from
17f4ea2 to
c9e9b52
Compare
daveawc
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This week, Github changed the
ubuntu-latestto Ubuntu 24. This broken our linting action where shellcheck keep on following with the following error:See: https://github.com/ministryofjustice/hmpps-temporary-accommodation-ui/actions/runs/12350577855/job/34517811023
We have seen this error before and it was an issue with github action runners. I noticed that the ubuntu version has been bumped and its most likely why shellcheck has broken again.
All the jobs also had the following warning from Github: ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see actions/runner-images#10636