Skip to content

Commit

Permalink
Pin Ubuntu version in github action to 22.04
Browse files Browse the repository at this point in the history
This week, Github changed the `ubuntu-latest` to Ubuntu 24. This broken our linting action where shellcheck keep on following with the following error:

```
Run npm run shellcheck

> [email protected] shellcheck
> npx shellcheck ./script/**/*[^utils] ./script/utils/**

[INFO ] ShellCheck binary not found or invalid, downloading to '/home/runner/work/hmpps-temporary-accommodation-ui/hmpps-temporary-accommodation-ui/node_modules/shellcheck/bin/shellcheck'
[INFO ] Downloading 'https://github.com/vscode-shellcheck/shellcheck-binaries/releases/download/v0.10.0/shellcheck-v0.10.0.linux.x86_64.tar.gz' to '/tmp/uNDjpK/shellcheck.download'
[INFO ] Extracting '/tmp/uNDjpK/shellcheck.download' to '/tmp/uNDjpK'
[INFO ] Copying '/tmp/uNDjpK/shellcheck' to '/home/runner/work/hmpps-temporary-accommodation-ui/hmpps-temporary-accommodation-ui/node_modules/shellcheck/bin/shellcheck'
[INFO ] ShellCheck binary successfully downloaded to '/home/runner/work/hmpps-temporary-accommodation-ui/hmpps-temporary-accommodation-ui/node_modules/shellcheck/bin/shellcheck'
./script/**/*[^utils]: ./script/**/*[^utils]: openBinaryFile: does not exist (No such file or directory)
Error: Process completed with exit code 2.

```
See: https://github.com/ministryofjustice/hmpps-temporary-accommodation-ui/actions/runs/12350577855/job/34517811023

We have seen this error before and it was an issue with github action runners. I noticed that the ubuntu version has been bumped and its most likely why shellcheck has broken again.

All the jobs also had the following warning from Github:
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see actions/runner-images#10636
  • Loading branch information
aliuk2012 committed Dec 17, 2024
1 parent 679d407 commit c9e9b52
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ env:
jobs:
type_checking:
name: "Type check 🔎"
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Check out code
uses: actions/[email protected]
Expand All @@ -33,7 +33,7 @@ jobs:

linting:
name: "Linting 🔎"
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Check out code
uses: actions/[email protected]
Expand All @@ -55,7 +55,7 @@ jobs:

unit_test:
name: "Unit testing 🧪"
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Check out code
uses: actions/[email protected]
Expand All @@ -74,7 +74,7 @@ jobs:

integration_test:
name: "Integration testing 🧪"
runs-on: ubuntu-latest
runs-on: ubuntu-22.04
steps:
- name: Check out code
uses: actions/[email protected]
Expand Down

0 comments on commit c9e9b52

Please sign in to comment.