Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for LegacyFabric #205

Merged
merged 4 commits into from
Mar 24, 2024
Merged

Support for LegacyFabric #205

merged 4 commits into from
Mar 24, 2024

Conversation

BluCobalt
Copy link
Contributor

Continuation of #197 but targetting v4.3 instead of main

@mindstorm38
Copy link
Owner

Thank you! It's really looking good. Could you fix (remove) modifications by your automatic formatter? This added many space in some places.

portablemc/cli/lang.py Show resolved Hide resolved
portablemc/cli/__init__.py Show resolved Hide resolved
portablemc/cli/__init__.py Show resolved Hide resolved
@mindstorm38
Copy link
Owner

Oops I'm on mobile and misclicked resolving, yes you're right about the message. You can just add precision for legacy fabric in parentheses.

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 63.73%. Comparing base (10b4b14) to head (e05430b).

Files Patch % Lines
portablemc/cli/__init__.py 0.00% 13 Missing ⚠️
portablemc/fabric.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             v4.3     #205      +/-   ##
==========================================
- Coverage   63.89%   63.73%   -0.17%     
==========================================
  Files          20       20              
  Lines        3271     3284      +13     
==========================================
+ Hits         2090     2093       +3     
- Misses       1181     1191      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mindstorm38
Copy link
Owner

(don't care of codecov)

@mindstorm38 mindstorm38 marked this pull request as ready for review March 23, 2024 22:10
@mindstorm38 mindstorm38 merged commit 235f059 into mindstorm38:v4.3 Mar 24, 2024
15 of 17 checks passed
@mindstorm38 mindstorm38 mentioned this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants