-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for LegacyFabric #205
Conversation
Thank you! It's really looking good. Could you fix (remove) modifications by your automatic formatter? This added many space in some places. |
Oops I'm on mobile and misclicked resolving, yes you're right about the message. You can just add precision for legacy fabric in parentheses. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v4.3 #205 +/- ##
==========================================
- Coverage 63.89% 63.73% -0.17%
==========================================
Files 20 20
Lines 3271 3284 +13
==========================================
+ Hits 2090 2093 +3
- Misses 1181 1191 +10 ☔ View full report in Codecov by Sentry. |
(don't care of codecov) |
Continuation of #197 but targetting v4.3 instead of main