Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.3 #204

Merged
merged 15 commits into from
Apr 21, 2024
Merged

Version 4.3 #204

merged 15 commits into from
Apr 21, 2024

Conversation

mindstorm38
Copy link
Owner

@mindstorm38 mindstorm38 commented Mar 10, 2024

Changes

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

Attention: Patch coverage is 31.53153% with 76 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@e98452a). Click here to learn what that means.

Files Patch % Lines
portablemc/cli/__init__.py 5.76% 49 Missing ⚠️
portablemc/auth.py 22.22% 7 Missing ⚠️
portablemc/fabric.py 75.86% 7 Missing ⚠️
portablemc/download.py 0.00% 5 Missing ⚠️
portablemc/standard.py 28.57% 5 Missing ⚠️
portablemc/cli/output.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #204   +/-   ##
=======================================
  Coverage        ?   63.60%           
=======================================
  Files           ?       20           
  Lines           ?     3314           
  Branches        ?        0           
=======================================
  Hits            ?     2108           
  Misses          ?     1206           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mindstorm38
Copy link
Owner Author

I should really really handle this PR now, it's been a month now.

@mindstorm38 mindstorm38 marked this pull request as ready for review April 16, 2024 17:38
@mindstorm38
Copy link
Owner Author

mindstorm38 commented Apr 16, 2024

Feel free to review, I'll wait until this weekend (april 20th) to release it, I also hope that I can fix #198 which is a rare problem yet insanely critical.

…starting. This allows CLI to print the command line without starting in "dry mode". Also added various verbose prints.
@mindstorm38
Copy link
Owner Author

Will be released later, probably around 23h UTC+2

@mindstorm38 mindstorm38 merged commit eb690c9 into main Apr 21, 2024
17 checks passed
@mindstorm38 mindstorm38 deleted the v4.3 branch April 21, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants