Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: report error when hints not supported #38717

Merged
merged 2 commits into from
Dec 25, 2024
Merged

fix: report error when hints not supported #38717

merged 2 commits into from
Dec 25, 2024

Conversation

chasingegg
Copy link
Contributor

issue: #38705

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 24, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 24, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.10%. Comparing base (636e107) to head (1342f38).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/query/PlanProto.cpp 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38717      +/-   ##
==========================================
+ Coverage   81.03%   81.10%   +0.06%     
==========================================
  Files        1380     1381       +1     
  Lines      195154   195250      +96     
==========================================
+ Hits       158145   158357     +212     
+ Misses      31438    31322     -116     
  Partials     5571     5571
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.34% <57.14%> (+<0.01%) ⬆️
Go 83.09% <ø> (+0.08%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/query/PlanProto.cpp 90.09% <57.14%> (-0.19%) ⬇️

... and 38 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 24, 2024
@mergify mergify bot removed the ci-passed label Dec 25, 2024
@chasingegg chasingegg mentioned this pull request Dec 25, 2024
Merged
@chasingegg
update
1342f38 
Signed-off-by: chasingegg <[email protected]>
@mergify mergify bot added the ci-passed label Dec 25, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 363d7f3 into milvus-io:master Dec 25, 2024
19 of 20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Dec 25, 2024
@chasingegg
fix: report error when hints not supported (#38730)
d47372e 
issue: #38705 
pr: #38717

---------

Signed-off-by: chasingegg <[email protected]>
@chasingegg chasingegg deleted the hints-param branch December 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chasingegg @czs007 @sre-ci-robot