Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report error when hints not supported #38730

Merged
merged 2 commits into from
Dec 25, 2024

Conversation

chasingegg
Copy link
Contributor

issue: #38705
pr: #38717

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 25, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 25, 2024
Signed-off-by: chasingegg <[email protected]>
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (bca21bd) to head (65e6d6c).
Report is 6 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/core/src/query/PlanProto.cpp 57.14% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38730      +/-   ##
==========================================
- Coverage   81.05%   81.03%   -0.02%     
==========================================
  Files        1381     1381              
  Lines      195110   195114       +4     
==========================================
- Hits       158137   158114      -23     
- Misses      31404    31422      +18     
- Partials     5569     5578       +9     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.34% <57.14%> (+<0.01%) ⬆️
Go 83.01% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/query/PlanProto.cpp 90.09% <57.14%> (-0.19%) ⬇️

... and 23 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 25, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 25, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chasingegg, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d47372e into milvus-io:2.5 Dec 25, 2024
18 of 20 checks passed
@chasingegg chasingegg deleted the hints-param-2.5 branch December 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants