fix: report error when hints not supported (#38717)

issue: #38705 --------- Signed-off-by: chasingegg <[email protected]>
milvus-io · Dec 25, 2024 · 363d7f3 · 363d7f3
1 parent c7ea09a
commit 363d7f3
Showing 1 changed file with 18 additions and 4 deletions.
diff --git a/internal/core/src/query/PlanProto.cpp b/internal/core/src/query/PlanProto.cpp
@@ -55,12 +55,26 @@ ProtoParser::PlanNodeFromProto(const planpb::PlanNode& plan_node_proto) {
             query_info_proto.materialized_view_involved();
         // currently, iterative filter does not support range search
         if (!search_info.search_params_.contains(RADIUS)) {
-            search_info.iterative_filter_execution =
-                (query_info_proto.hints() == ITERATIVE_FILTER);
+            if (query_info_proto.hints() != "") {
+                if (query_info_proto.hints() == ITERATIVE_FILTER) {
+                    search_info.iterative_filter_execution = true;
+                } else {
+                    // check if hints is valid
+                    PanicInfo(ConfigInvalid,
+                              "hints: {} not supported",
+                              query_info_proto.hints());
+                }
+            }
             if (!search_info.iterative_filter_execution &&
                 search_info.search_params_.contains(HINTS)) {
-                search_info.iterative_filter_execution =
-                    (search_info.search_params_[HINTS] == ITERATIVE_FILTER);
+                if (search_info.search_params_[HINTS] == ITERATIVE_FILTER) {
+                    search_info.iterative_filter_execution = true;
+                } else {
+                    // check if hints is valid
+                    PanicInfo(ConfigInvalid,
+                              "hints: {} not supported",
+                              search_info.search_params_[HINTS]);
+                }
             }
         }