Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: field stringtype maxlength raise to 1M #38592

Merged
merged 1 commit into from
Dec 20, 2024
Merged

enhance: field stringtype maxlength raise to 1M #38592

merged 1 commit into from
Dec 20, 2024

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 19, 2024

enhance: field stringtype maxlength raise to 1M
issue: #37436

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (8fcb33c) to head (b2a4e28).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/proxy/task.go 0.00% 1 Missing ⚠️
internal/proxy/util.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38592      +/-   ##
==========================================
+ Coverage   81.00%   81.02%   +0.02%     
==========================================
  Files        1379     1379              
  Lines      194495   194524      +29     
==========================================
+ Hits       157546   157618      +72     
+ Misses      31393    31363      -30     
+ Partials     5556     5543      -13
Components Coverage Δ
Client 75.88% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.06% <0.00%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/task.go 80.69% <0.00%> (ø)
internal/proxy/util.go 89.63% <0.00%> (ø)

... and 32 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added area/test sig/testing size/S Denotes a PR that changes 10-29 lines. and removed size/XS Denotes a PR that changes 0-9 lines. labels Dec 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 19, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove JsDove force-pushed the raise_maxlength branch 2 times, most recently from 3c9465e to 4b2128f Compare December 20, 2024 01:51
@JsDove
field stringtype maxlength raise to 1M
b2a4e28 
Signed-off-by: Xianhui.Lin <[email protected]>

fix invalidstringfiledtype ut

Signed-off-by: Xianhui.Lin <[email protected]>

fix invalidstringfiledtype ut

Signed-off-by: Xianhui.Lin <[email protected]>

fix invalidstringfiledtype ut

Signed-off-by: Xianhui.Lin <[email protected]>

fix invalidstringfiledtype ut

Signed-off-by: Xianhui.Lin <[email protected]>
@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 20, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Dec 20, 2024

/run-cpu-e2e

@JsDove
Copy link
Contributor Author

JsDove commented Dec 20, 2024

rerun go-sdk

@JsDove
Copy link
Contributor Author

JsDove commented Dec 20, 2024

run ut

@JsDove
Copy link
Contributor Author

JsDove commented Dec 20, 2024

/run-cpu-e2e

@JsDove
Copy link
Contributor Author

JsDove commented Dec 20, 2024

rerun ut

@mergify mergify bot added the ci-passed label Dec 20, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 20, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 90de37e into milvus-io:master Dec 20, 2024
19 of 20 checks passed
@JsDove JsDove mentioned this pull request Dec 20, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Dec 20, 2024
@JsDove
enhance: [2.5]field stringtype maxlength raise to 1M (#38614)
3cf9b6b 
enhance: field stringtype maxlength raise to 1M
issue: #37436
master pr: #38592

Signed-off-by: Xianhui.Lin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JsDove @czs007 @sre-ci-robot