Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5]field stringtype maxlength raise to 1M #38614

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 20, 2024

enhance: field stringtype maxlength raise to 1M
issue: #37436
master pr: #38592

Signed-off-by: Xianhui.Lin <[email protected]>

fix invalidstringfiledtype ut

Signed-off-by: Xianhui.Lin <[email protected]>

fix invalidstringfiledtype ut

Signed-off-by: Xianhui.Lin <[email protected]>

fix invalidstringfiledtype ut

Signed-off-by: Xianhui.Lin <[email protected]>

fix invalidstringfiledtype ut

Signed-off-by: Xianhui.Lin <[email protected]>
@sre-ci-robot sre-ci-robot added area/test sig/testing size/S Denotes a PR that changes 10-29 lines. labels Dec 20, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 20, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 20, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Dec 20, 2024

@JsDove go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 81.04%. Comparing base (b132438) to head (6287367).
Report is 1 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/task.go 0.00% 1 Missing ⚠️
internal/proxy/util.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38614      +/-   ##
==========================================
- Coverage   81.05%   81.04%   -0.02%     
==========================================
  Files        1381     1381              
  Lines      195090   195090              
==========================================
- Hits       158137   158107      -30     
- Misses      31386    31414      +28     
- Partials     5567     5569       +2     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.02% <0.00%> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/task.go 80.69% <0.00%> (ø)
internal/proxy/util.go 89.45% <0.00%> (ø)

... and 37 files with indirect coverage changes

@JsDove
Copy link
Contributor Author

JsDove commented Dec 20, 2024

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 20, 2024
@sre-ci-robot sre-ci-robot merged commit 3cf9b6b into milvus-io:2.5 Dec 20, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants