Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] Add bulk import restful API wrapper #38493

Conversation

congqixia
Copy link
Contributor

Related to #31293

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Dec 16, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 72.66187% with 38 lines in your changes missing coverage. Please review.

Project coverage is 80.96%. Comparing base (01fa2f8) to head (92e7cbb).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
client/bulkwriter/bulk_import.go 72.66% 31 Missing and 7 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38493      +/-   ##
==========================================
+ Coverage   80.92%   80.96%   +0.04%     
==========================================
  Files        1377     1378       +1     
  Lines      193866   194005     +139     
==========================================
+ Hits       156887   157078     +191     
+ Misses      31442    31405      -37     
+ Partials     5537     5522      -15     
Components Coverage Δ
Client 74.52% <72.66%> (-0.07%) ⬇️
Core 68.97% <ø> (ø)
Go 83.07% <ø> (+0.05%) ⬆️
Files with missing lines Coverage Δ
client/bulkwriter/bulk_import.go 72.66% <72.66%> (ø)

... and 33 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 16, 2024
@congqixia congqixia force-pushed the enhance/gosdk/support_restful_bulkimport branch from fe35d45 to 92e7cbb Compare December 17, 2024 05:38
@bigsheeper
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Dec 17, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Dec 17, 2024
@sre-ci-robot sre-ci-robot merged commit e19a4f7 into milvus-io:master Dec 17, 2024
18 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Dec 19, 2024
sre-ci-robot pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants