Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] Add content-type header for bulk import req #38581

Merged

Conversation

congqixia
Copy link
Contributor

Related to #31293
Previous PR: #38493

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 19, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.00%. Comparing base (306e5e6) to head (5a419d9).
Report is 5 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #38581   +/-   ##
=======================================
  Coverage   80.99%   81.00%           
=======================================
  Files        1379     1379           
  Lines      194492   194500    +8     
=======================================
+ Hits       157523   157547   +24     
+ Misses      31403    31390   -13     
+ Partials     5566     5563    -3     
Components Coverage Δ
Client 75.90% <100.00%> (+0.01%) ⬆️
Core 69.33% <ø> (+<0.01%) ⬆️
Go 83.03% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
client/bulkwriter/bulk_import.go 73.23% <100.00%> (+0.57%) ⬆️

... and 30 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Dec 19, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit a728646 into milvus-io:master Dec 20, 2024
20 checks passed
@congqixia congqixia deleted the enhance/gosdk/ctype_header_importreq branch December 23, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants