Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Reduce mutex contention in datacoord meta #38219

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Merge branch 'master' of https://github.com/milvus-io/milvus into 241…

1f8c0b5
Select commit
Loading
Failed to load commit list.
Open

enhance: Reduce mutex contention in datacoord meta #38219

Merge branch 'master' of https://github.com/milvus-io/milvus into 241…
1f8c0b5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 17, 2024 in 0s

82.79% (target 77.00%)

View this Pull Request on Codecov

82.79% (target 77.00%)

Details

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (2afe2ea) to head (1f8c0b5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/meta.go 33.33% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38219      +/-   ##
==========================================
+ Coverage   80.91%   82.79%   +1.88%     
==========================================
  Files        1375     1083     -292     
  Lines      193645   167515   -26130     
==========================================
- Hits       156692   138699   -17993     
+ Misses      31418    23286    -8132     
+ Partials     5535     5530       -5     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.03% <72.72%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/compaction_policy_clustering.go 75.48% <100.00%> (-0.12%) ⬇️
internal/datacoord/compaction_policy_single.go 61.00% <100.00%> (-0.39%) ⬇️
internal/datacoord/compaction_trigger.go 83.97% <100.00%> (-1.17%) ⬇️
internal/datacoord/meta.go 89.27% <33.33%> (-0.37%) ⬇️

... and 319 files with indirect coverage changes