-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: Reduce mutex contention in datacoord meta #38219
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bigsheeper The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@bigsheeper go-sdk check failed, comment |
@bigsheeper E2e jenkins job failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38219 +/- ##
==========================================
+ Coverage 80.91% 82.79% +1.88%
==========================================
Files 1375 1083 -292
Lines 193645 167515 -26130
==========================================
- Hits 156692 138699 -17993
+ Misses 31418 23286 -8132
+ Partials 5535 5530 -5
|
Signed-off-by: bigsheeper <[email protected]>
43ec0aa
to
bae195c
Compare
1. Using secondary index to avoid retrieving all segments at GetSegmentsChanPart. 2. Perform batch SetAllocations to reduce the number of times the meta lock is acquired. issue: #37630 pr: #38219 --------- Signed-off-by: bigsheeper <[email protected]>
@bigsheeper go-sdk check failed, comment |
@bigsheeper E2e jenkins job failed, comment |
…2-opt-meta-mutex
Signed-off-by: bigsheeper <[email protected]>
@bigsheeper go-sdk check failed, comment |
…2-opt-meta-mutex
@bigsheeper go-sdk check failed, comment |
rerun go-sdk |
GetSegmentsChanPart
.issue: #37630