Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Reduce mutex contention in datacoord meta #38219

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

bigsheeper
Copy link
Contributor

  1. Using secondary index to avoid retrieving all segments at GetSegmentsChanPart.
  2. Perform batch SetAllocations to reduce the number of times the meta lock is acquired.

issue: #37630

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 4, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 4, 2024
Copy link
Contributor

mergify bot commented Dec 4, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 4, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 4, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.79%. Comparing base (2afe2ea) to head (1f8c0b5).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
internal/datacoord/meta.go 33.33% 6 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38219      +/-   ##
==========================================
+ Coverage   80.91%   82.79%   +1.88%     
==========================================
  Files        1375     1083     -292     
  Lines      193645   167515   -26130     
==========================================
- Hits       156692   138699   -17993     
+ Misses      31418    23286    -8132     
+ Partials     5535     5530       -5     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.03% <72.72%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/compaction_policy_clustering.go 75.48% <100.00%> (-0.12%) ⬇️
internal/datacoord/compaction_policy_single.go 61.00% <100.00%> (-0.39%) ⬇️
internal/datacoord/compaction_trigger.go 83.97% <100.00%> (-1.17%) ⬇️
internal/datacoord/meta.go 89.27% <33.33%> (-0.37%) ⬇️

... and 319 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 5, 2024
czs007 pushed a commit that referenced this pull request Dec 5, 2024
1. Using secondary index to avoid retrieving all segments at
GetSegmentsChanPart.
2. Perform batch SetAllocations to reduce the number of times the meta
lock is acquired.

issue: #37630

pr: #38219

---------

Signed-off-by: bigsheeper <[email protected]>
Copy link
Contributor

mergify bot commented Dec 5, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 5, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Dec 5, 2024
Signed-off-by: bigsheeper <[email protected]>
@mergify mergify bot removed the ci-passed label Dec 13, 2024
Copy link
Contributor

mergify bot commented Dec 13, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 17, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants