Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Modify the documentation of the Demos and Tutorials chapter (#38054) #38057

Merged
merged 2 commits into from
Nov 28, 2024
Merged

fix: Modify the documentation of the Demos and Tutorials chapter (#38054) #38057

merged 2 commits into from
Nov 28, 2024

Conversation

HuaSheng2000
Copy link
Contributor

@HuaSheng2000 HuaSheng2000 commented Nov 27, 2024 •
edited
Loading

issue: #38054

  • Delete the table about tutorials in the English document, use link to replace the existing table, and add corresponding descriptions (the table content is outdated, and using link can reduce maintenance costs).
  • Add link and corresponding descriptions of tutorials in Chinese documentation.

@sre-ci-robot
Copy link
Contributor

Welcome @HuaSheng2000! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024

@HuaSheng2000 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. ci-passed kind/bug Issues or changes related a bug labels Nov 27, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 27, 2024

@HuaSheng2000 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@HuaSheng2000 HuaSheng2000 force-pushed the fix/issue-38054-tutorials-link branch from 1c6a6b8 to 8035d5e Compare November 27, 2024 12:35
@HuaSheng2000 HuaSheng2000 force-pushed the fix/issue-38054-tutorials-link branch from 8035d5e to bb395a6 Compare November 27, 2024 12:46
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Nov 27, 2024
@HuaSheng2000
Copy link
Contributor Author

/assign @congqixia

yanliang567
yanliang567 reviewed Nov 27, 2024
View reviewed changes
README.md Show resolved Hide resolved
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Nov 27, 2024
@yanliang567
Copy link
Contributor

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuaSheng2000, yanliang567

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 6aaa926 into milvus-io:master Nov 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunby sunby Awaiting requested review from sunby

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@yanliang567 yanliang567

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HuaSheng2000 @sre-ci-robot @yanliang567 @congqixia