Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[2.5]GrowingDataGetter get the wrong string data #38016

Closed
wants to merge 1 commit into from
Closed

fix:[2.5]GrowingDataGetter get the wrong string data #38016

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/core/src/exec/operator/groupby/SearchGroupByOperator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,11 @@

T
Get(int64_t idx) const {
return growing_raw_data_->operator[](idx);
if constexpr (std::is_same_v<std::string, T>) {
return T(growing_raw_data_->view_element(idx));

Check warning on line 54 in internal/core/src/exec/operator/groupby/SearchGroupByOperator.h

View check run for this annotation

Codecov / codecov/patch

internal/core/src/exec/operator/groupby/SearchGroupByOperator.h#L54 

Added line #L54 was not covered by tests
} else {
return growing_raw_data_->operator[](idx);
}
}
};

Expand Down
Loading