Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:[2.5]GrowingDataGetter get the wrong string data #38016

Closed
wants to merge 1 commit into from

Conversation

cqy123456
Copy link
Contributor

issue: #37994
master pr: #38015
2.4 pr: #37995

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 26, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (c35045e) to head (84b88ef).
Report is 4 commits behind head on 2.5.

Files with missing lines Patch % Lines
.../src/exec/operator/groupby/SearchGroupByOperator.h 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38016      +/-   ##
==========================================
- Coverage   81.04%   81.03%   -0.01%     
==========================================
  Files        1360     1360              
  Lines      190664   190665       +1     
==========================================
- Hits       154515   154508       -7     
- Misses      30655    30656       +1     
- Partials     5494     5501       +7     
Components Coverage Δ
Client 72.16% <ø> (ø)
Core 68.87% <50.00%> (-0.01%) ⬇️
Go 83.20% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
.../src/exec/operator/groupby/SearchGroupByOperator.h 80.88% <50.00%> (-1.21%) ⬇️

... and 31 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 26, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

1 similar comment
@cqy123456
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 26, 2024
@cqy123456 cqy123456 closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants