Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Accelerate the loading of collection #37741

Closed

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Nov 16, 2024

Remove unnecessary ListIndex and DescribeCollection RPC call during loading.

issue: #37166

@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/internal-api labels Nov 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 16, 2024
Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 16, 2024
Copy link
Contributor

mergify bot commented Nov 16, 2024

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 16, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (c73ca14) to head (7729e6c).
Report is 180 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37741       +/-   ##
===========================================
+ Coverage   68.87%   81.04%   +12.16%     
===========================================
  Files         289     1357     +1068     
  Lines       25481   190168   +164687     
===========================================
+ Hits        17551   154127   +136576     
- Misses       7930    30577    +22647     
- Partials        0     5464     +5464     
Components Coverage Δ
Client 72.16% <ø> (∅)
Core 68.87% <ø> (ø)
Go 83.22% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/querycoordv2/job/job_load.go 85.71% <100.00%> (ø)
internal/querycoordv2/job/job_sync.go 75.55% <100.00%> (ø)
internal/querycoordv2/job/utils.go 83.33% <100.00%> (ø)

... and 1065 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chyezh
Copy link
Contributor

chyezh commented Nov 18, 2024

\lgtm

Copy link
Contributor

mergify bot commented Nov 18, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@czs007 czs007 added this to the 2.5.0 milestone Nov 19, 2024
@czs007 czs007 modified the milestones: 2.5.0, 2.5.1 Nov 19, 2024
Copy link
Contributor

mergify bot commented Nov 19, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 19, 2024

@bigsheeper E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@bigsheeper bigsheeper added the 10kcp PR related to 10k collection partitions Project label Nov 20, 2024
@bigsheeper
Copy link
Contributor Author

also related: #37630

Copy link
Contributor

mergify bot commented Nov 20, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 20, 2024

@bigsheeper cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Nov 20, 2024
@chyezh
Copy link
Contributor

chyezh commented Nov 21, 2024

/lgtm

czs007 pushed a commit that referenced this pull request Nov 21, 2024
Remove unnecessary ListIndex and DescribeCollection RPC call during
loading.

issue: #37166,
#37630

pr: #37741

Signed-off-by: bigsheeper <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Nov 29, 2024
Remove unnecessary ListIndex and DescribeCollection RPC call during
loading.

issue: #37166,
#37630

pr: #37741

Signed-off-by: bigsheeper <[email protected]>
@bigsheeper
Copy link
Contributor Author

close due to #38059

@bigsheeper bigsheeper closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10kcp PR related to 10k collection partitions Project area/internal-api ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants