Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [10kcp] Accelerate the loading of collection #37879

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

bigsheeper
Copy link
Contributor

Remove unnecessary ListIndex and DescribeCollection RPC call during loading.

issue: #37166, #37630

pr: #37741

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bigsheeper
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 21, 2024
@czs007 czs007 merged commit ac7b485 into milvus-io:10kcp Nov 21, 2024
7 of 9 checks passed
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.62%. Comparing base (0bd2617) to head (8513ed7).
Report is 7 commits behind head on 10kcp.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            10kcp   #37879      +/-   ##
==========================================
- Coverage   80.63%   80.62%   -0.02%     
==========================================
  Files        1069     1069              
  Lines      166978   166968      -10     
==========================================
- Hits       134643   134616      -27     
- Misses      27930    27944      +14     
- Partials     4405     4408       +3     
Files with missing lines Coverage Δ
internal/querycoordv2/job/job_load.go 85.71% <100.00%> (-3.73%) ⬇️
internal/querycoordv2/job/job_sync.go 75.55% <100.00%> (ø)
internal/querycoordv2/job/utils.go 83.33% <100.00%> (+1.62%) ⬆️

... and 30 files with indirect coverage changes

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants