Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: update knowhere version #37688

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Nov 14, 2024

issue: #37665 #37631 #37620 #37587 #36906
knowhere has add default nlist value, so some invalid param test ut with no nlist param will be valid.

@sre-ci-robot sre-ci-robot added area/compilation size/XS Denotes a PR that changes 0-9 lines. labels Nov 14, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@foxspy

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Nov 14, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

@foxspy foxspy force-pushed the update_knowhere_version branch from ff16b09 to 02a32d0 Compare November 14, 2024 11:39
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.65%. Comparing base (405c12f) to head (db5f491).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37688       +/-   ##
===========================================
+ Coverage   68.07%   80.65%   +12.58%     
===========================================
  Files         290     1357     +1067     
  Lines       25457   190661   +165204     
===========================================
+ Hits        17329   153774   +136445     
- Misses       8128    31467    +23339     
- Partials        0     5420     +5420     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.64% <ø> (+0.57%) ⬆️
Go 83.20% <ø> (∅)

see 1073 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Nov 14, 2024

/approve
/lgtm

Copy link
Contributor

mergify bot commented Nov 14, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the update_knowhere_version branch from 02a32d0 to 4e2354e Compare November 14, 2024 14:02
@sre-ci-robot sre-ci-robot removed the lgtm label Nov 14, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Nov 14, 2024

@foxspy Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Nov 14, 2024
@foxspy foxspy force-pushed the update_knowhere_version branch from 4e2354e to 3795a42 Compare November 14, 2024 14:05
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Nov 14, 2024
Copy link
Contributor

mergify bot commented Nov 14, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 14, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: xianliang.li <[email protected]>
@foxspy foxspy force-pushed the update_knowhere_version branch from 3795a42 to db5f491 Compare November 14, 2024 16:03
@mergify mergify bot added the ci-passed label Nov 14, 2024
@foxspy foxspy changed the title enhance : update knowhere version enhance: update knowhere version Nov 15, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 15, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 15, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 5ae347a into milvus-io:master Nov 15, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants