-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: update knowhere version #37688
Conversation
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
@foxspy go-sdk check failed, comment |
ff16b09
to
02a32d0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37688 +/- ##
===========================================
+ Coverage 68.07% 80.65% +12.58%
===========================================
Files 290 1357 +1067
Lines 25457 190661 +165204
===========================================
+ Hits 17329 153774 +136445
- Misses 8128 31467 +23339
- Partials 0 5420 +5420
|
/approve |
@foxspy E2e jenkins job failed, comment |
02a32d0
to
4e2354e
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@foxspy Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco. |
4e2354e
to
3795a42
Compare
@foxspy go-sdk check failed, comment |
@foxspy E2e jenkins job failed, comment |
Signed-off-by: xianliang.li <[email protected]>
3795a42
to
db5f491
Compare
/lgtm |
issue: #37665 #37631 #37620 #37587 #36906
knowhere has add default nlist value, so some invalid param test ut with no nlist param will be valid.