Skip to content

Commit

Permalink
update knowhere version
Browse files Browse the repository at this point in the history
Signed-off-by: xianliang.li <[email protected]>
  • Loading branch information
foxspy committed Nov 14, 2024
1 parent 405c12f commit 02a32d0
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion internal/core/thirdparty/knowhere/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
# Update KNOWHERE_VERSION for the first occurrence
milvus_add_pkg_config("knowhere")
set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "")
set( KNOWHERE_VERSION 5935c1f )
set( KNOWHERE_VERSION 0bb86e3 )
set( GIT_REPOSITORY "https://github.com/zilliztech/knowhere.git")
message(STATUS "Knowhere repo: ${GIT_REPOSITORY}")
message(STATUS "Knowhere version: ${KNOWHERE_VERSION}")
Expand Down
4 changes: 2 additions & 2 deletions internal/proxy/task_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -2369,7 +2369,7 @@ func Test_checkTrain(t *testing.T) {
assert.Error(t, checkTrain(f, m))
})

t.Run("invalid params", func(t *testing.T) {
t.Run("nlist test", func(t *testing.T) {
f := &schemapb.FieldSchema{
DataType: schemapb.DataType_FloatVector,
IndexParams: []*commonpb.KeyValuePair{
Expand All @@ -2383,7 +2383,7 @@ func Test_checkTrain(t *testing.T) {
common.IndexTypeKey: "IVF_FLAT",
common.MetricTypeKey: "L2",
}
assert.Error(t, checkTrain(f, m))
assert.NoError(t, checkTrain(f, m))
})
}

Expand Down

0 comments on commit 02a32d0

Please sign in to comment.