-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: RBAC custom privilege group ut coverage #37558
Conversation
Invalid PR Title Format Detected Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:
Required Title Structure:
Where Example:
Please review and update your PR to comply with these guidelines. |
Signed-off-by: shaoting-huang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37558 +/- ##
===========================================
- Coverage 82.42% 68.13% -14.30%
===========================================
Files 1066 290 -776
Lines 164588 25395 -139193
===========================================
- Hits 135665 17302 -118363
+ Misses 23497 8093 -15404
+ Partials 5426 0 -5426
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: milvus-io#37031 Signed-off-by: shaoting-huang <[email protected]>
Related to milvus-io#37558 Signed-off-by: Congqi Xia <[email protected]>
Cherry-pick from master pr: #37087, #37558 issue: #37031 --------- Signed-off-by: shaoting-huang <[email protected]>
Related to #37558 --------- Signed-off-by: Congqi Xia <[email protected]>
issue: #37031