Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: RBAC custom privilege group ut coverage #37558

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

shaoting-huang
Copy link
Contributor

issue: #37031

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/test sig/testing test/integration integration test labels Nov 9, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Nov 9, 2024
Copy link
Contributor

mergify bot commented Nov 9, 2024

@shaoting-huang

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@shaoting-huang shaoting-huang changed the title RBAC custom privilege group ut coverage enhance: RBAC custom privilege group ut coverage Nov 9, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Nov 9, 2024
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (70605cf) to head (d8a2cb2).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37558       +/-   ##
===========================================
- Coverage   82.42%   68.13%   -14.30%     
===========================================
  Files        1066      290      -776     
  Lines      164588    25395   -139193     
===========================================
- Hits       135665    17302   -118363     
+ Misses      23497     8093    -15404     
+ Partials     5426        0     -5426     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <ø> (∅)
Go ∅ <ø> (∅)

see 1356 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 9, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit ff00a12 into milvus-io:master Nov 9, 2024
18 of 20 checks passed
shaoting-huang added a commit to shaoting-huang/milvus that referenced this pull request Nov 9, 2024
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 11, 2024
sre-ci-robot pushed a commit that referenced this pull request Nov 11, 2024
Cherry-pick from master
pr: #37087,
#37558
issue: #37031

---------

Signed-off-by: shaoting-huang <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants