Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4] RBAC custom privilege group #37560

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

shaoting-huang
Copy link
Contributor

Cherry-pick from master
pr: #37087, #37558
issue: #37031

@sre-ci-robot sre-ci-robot added area/internal-api area/test sig/testing test/integration integration test size/XXL Denotes a PR that changes 1000+ lines. labels Nov 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 9, 2024
Copy link
Contributor

mergify bot commented Nov 9, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Nov 10, 2024
Copy link
Contributor

mergify bot commented Nov 10, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

2 similar comments
Copy link
Contributor

mergify bot commented Nov 10, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 11, 2024

@shaoting-huang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 76.84347% with 179 lines in your changes missing coverage. Please review.

Project coverage is 72.23%. Comparing base (cedc340) to head (48c3a5d).
Report is 3 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/rootcoord/root_coord.go 75.00% 46 Missing and 16 partials ⚠️
internal/metastore/kv/rootcoord/kv_catalog.go 53.46% 35 Missing and 12 partials ⚠️
internal/rootcoord/meta_table.go 73.88% 31 Missing and 10 partials ⚠️
internal/proxy/impl.go 74.10% 21 Missing and 8 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37560      +/-   ##
==========================================
- Coverage   80.61%   72.23%   -8.39%     
==========================================
  Files        1069     1069              
  Lines      165966   166714     +748     
==========================================
- Hits       133794   120419   -13375     
- Misses      27812    41887   +14075     
- Partials     4360     4408      +48     
Files with missing lines Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go 91.31% <100.00%> (+0.32%) ⬆️
...nternal/distributed/proxy/httpserver/request_v2.go 100.00% <ø> (ø)
internal/distributed/proxy/service.go 85.15% <100.00%> (+0.15%) ⬆️
internal/distributed/rootcoord/client/client.go 95.51% <100.00%> (+0.36%) ⬆️
internal/distributed/rootcoord/service.go 80.19% <100.00%> (+0.53%) ⬆️
internal/metastore/catalog.go 100.00% <ø> (ø)
...ernal/metastore/kv/rootcoord/rootcoord_constant.go 100.00% <100.00%> (ø)
internal/proxy/meta_cache.go 91.43% <100.00%> (+0.06%) ⬆️
internal/proxy/util.go 90.64% <ø> (-0.03%) ⬇️
internal/util/mock/grpc_rootcoord_client.go 86.99% <100.00%> (+6.12%) ⬆️
... and 7 more

... and 232 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 11, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, shaoting-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9e8b6ac into milvus-io:2.4 Nov 11, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file area/internal-api area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants