Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct dropped segment num metrics #37410

Merged
merged 1 commit into from
Nov 7, 2024
Merged

fix: Correct dropped segment num metrics #37410

merged 1 commit into from
Nov 7, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #31891

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 4, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 4, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@czs007
Copy link
Collaborator

czs007 commented Nov 4, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 4, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Nov 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.03%. Comparing base (c83b939) to head (9d70d19).
Report is 14 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37410       +/-   ##
===========================================
+ Coverage   67.37%   81.03%   +13.66%     
===========================================
  Files         290     1305     +1015     
  Lines       25378   182857   +157479     
===========================================
+ Hits        17098   148178   +131080     
- Misses       8280    29474    +21194     
- Partials        0     5205     +5205
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.37% <ø> (ø)
Go 83.26% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.24% <100.00%> (ø)

... and 1014 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 5, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Nov 6, 2024
@XuanYang-cn
fix: [cp24]Correct dropped segment num metrics
5ba7871 
See also: milvus-io#31891
pr: milvus-io#37410

Signed-off-by: yangxuan <[email protected]>
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Nov 6, 2024
@XuanYang-cn
fix: [cp25]Correct dropped segment num metrics
631125b 
See also: milvus-io#31891
pr: milvus-io#37410

Signed-off-by: yangxuan <[email protected]>
This was referenced Nov 6, 2024
Closed
Merged
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 6, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Nov 6, 2024
@weiliu1031
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 51ed2a6 into milvus-io:master Nov 7, 2024
20 checks passed
@XuanYang-cn XuanYang-cn deleted the fix-dropped-metric branch November 7, 2024 06:11
sre-ci-robot pushed a commit that referenced this pull request Nov 7, 2024
@XuanYang-cn
fix: [cp24]Correct dropped segment num metrics (#37471)
dd0cf20 
See also: #31891
pr: #37410

---------

Signed-off-by: yangxuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@weiliu1031 weiliu1031

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuanYang-cn @czs007 @sre-ci-robot @weiliu1031