Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [cp25]Correct dropped segment num metrics #37470

Closed

Conversation

XuanYang-cn
Copy link
Contributor

See also: #31891
pr: #37410

@sre-ci-robot sre-ci-robot requested review from cydrain and sunby November 6, 2024 06:48
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 6, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 6, 2024
@XuanYang-cn XuanYang-cn closed this Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.96%. Comparing base (8ba0a4a) to head (631125b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              2.5   #37470   +/-   ##
=======================================
  Coverage   80.95%   80.96%           
=======================================
  Files        1305     1305           
  Lines      182900   182899    -1     
=======================================
+ Hits       148069   148076    +7     
+ Misses      29627    29621    -6     
+ Partials     5204     5202    -2     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 66.94% <ø> (+0.01%) ⬆️
Go 83.24% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/meta.go 89.24% <100.00%> (+0.19%) ⬆️

... and 21 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants