Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dead lock if query node crash during shard client init #37354

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Nov 1, 2024

issue: #37115

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Nov 1, 2024
@weiliu1031
Copy link
Contributor Author

/branch-feature

@mergify mergify bot added the dco-passed DCO check passed. label Nov 1, 2024
Copy link
Contributor

mergify bot commented Nov 1, 2024

@weiliu1031 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Nov 1, 2024
Copy link
Contributor

mergify bot commented Nov 1, 2024

@weiliu1031 Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@weiliu1031
Copy link
Contributor Author

/kind branch-feature

Copy link
Contributor

mergify bot commented Nov 1, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 1, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

rerun ut

1 similar comment
@weiliu1031
Copy link
Contributor Author

rerun ut

@weiliu1031
Copy link
Contributor Author

rerun ut

1 similar comment
@weiliu1031
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Nov 4, 2024
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.16%. Comparing base (37d691f) to head (481fefd).
Report is 9 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/proxy/shard_client.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37354      +/-   ##
==========================================
- Coverage   79.05%   72.16%   -6.89%     
==========================================
  Files        1061     1069       +8     
  Lines      164564   165667    +1103     
==========================================
- Hits       130088   119557   -10531     
- Misses      30108    41750   +11642     
+ Partials     4368     4360       -8     
Files with missing lines Coverage Δ
internal/proxy/shard_client.go 82.60% <0.00%> (-0.52%) ⬇️

... and 388 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Nov 5, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit eb712f0 into milvus-io:2.4 Nov 5, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants