Skip to content

Commit

Permalink
fix: dead lock if query node crash during shard client init
Browse files Browse the repository at this point in the history
Signed-off-by: Wei Liu <[email protected]>
  • Loading branch information
weiliu1031 committed Nov 4, 2024
1 parent 4fb86eb commit 481fefd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions internal/proxy/shard_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ func (n *shardClient) getClient(ctx context.Context) (types.QueryNodeClient, err
n.Lock()
if !n.initialized.Load() {
if err := n.initClients(); err != nil {
n.Unlock()

Check warning on line 50 in internal/proxy/shard_client.go

View check run for this annotation

Codecov / codecov/patch

internal/proxy/shard_client.go#L50

Added line #L50 was not covered by tests
return nil, err
}
n.initialized.Store(true)
Expand Down

0 comments on commit 481fefd

Please sign in to comment.