Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Update Knowhere version #37333

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

foxspy
Copy link
Contributor

@foxspy foxspy commented Oct 31, 2024

issue: #37269

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Oct 31, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Oct 31, 2024
Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the update_knowhere_version branch from be807e1 to 32684f1 Compare October 31, 2024 09:53
Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (d119a25) to head (47eadff).
Report is 7 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37333      +/-   ##
==========================================
- Coverage   83.24%   80.99%   -2.25%     
==========================================
  Files        1015     1305     +290     
  Lines      157421   182858   +25437     
==========================================
+ Hits       131040   148114   +17074     
- Misses      21184    29545    +8361     
- Partials     5197     5199       +2     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 67.17% <ø> (∅)
Go 83.25% <81.31%> (-0.02%) ⬇️

see 322 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Oct 31, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy foxspy force-pushed the update_knowhere_version branch 2 times, most recently from c916c80 to ccc2277 Compare October 31, 2024 11:52
@yellow-shine
Copy link
Collaborator

rerun cpp-unit-test

1 similar comment
@yellow-shine
Copy link
Collaborator

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

rerun go-sdk

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: xianliang.li <[email protected]>
@foxspy foxspy force-pushed the update_knowhere_version branch from ccc2277 to 47eadff Compare November 1, 2024 08:44
Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 1, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 1, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 3, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 3, 2024

@foxspy E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@foxspy
Copy link
Contributor Author

foxspy commented Nov 4, 2024

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 4, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, foxspy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c27f477 into milvus-io:master Nov 4, 2024
18 of 20 checks passed
@mergify mergify bot removed the ci-passed label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants