update Knowhere Version

Signed-off-by: xianliang.li <[email protected]>
milvus-io · Oct 31, 2024 · ccc2277 · ccc2277
1 parent 4bac2eb
commit ccc2277
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/.github/workflows/update-knowhere-commit.yaml b/.github/workflows/update-knowhere-commit.yaml
@@ -29,6 +29,7 @@ jobs:
         id: get-knowhere-latest-commit
         run: | 
           cd ..
+          rm -fr Knowhere
           git clone https://github.com/zilliztech/Knowhere.git
           cd Knowhere
           export commit=$(git rev-parse --short HEAD)

diff --git a/internal/core/thirdparty/knowhere/CMakeLists.txt b/internal/core/thirdparty/knowhere/CMakeLists.txt
@@ -14,7 +14,7 @@
 # Update KNOWHERE_VERSION for the first occurrence
 milvus_add_pkg_config("knowhere")
 set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "")
-set( KNOWHERE_VERSION ecc27ac )
+set( KNOWHERE_VERSION e67abe7 )
 set( GIT_REPOSITORY  "https://github.com/zilliztech/knowhere.git")
 message(STATUS "Knowhere repo: ${GIT_REPOSITORY}")
 message(STATUS "Knowhere version: ${KNOWHERE_VERSION}")

diff --git a/tests/go_client/testcases/index_test.go b/tests/go_client/testcases/index_test.go
@@ -1004,7 +1004,7 @@ func TestCreateIndexInvalidParams(t *testing.T) {
 
 	idxIvfPq := index.NewIvfPQIndex(entity.L2, 128, 7, 8)
 	_, err := mc.CreateIndex(ctx, client.NewCreateIndexOption(schema.CollectionName, common.DefaultFloatVecFieldName, idxIvfPq))
-	common.CheckErr(t, err, false, "dimension must be able to be divided by `m`")
+	common.CheckErr(t, err, false, "The dimension of a vector (dim) should be a multiple of the number of subquantizers")
 
 	// invalid Hnsw M [1, 2048], efConstruction [1, 2147483647]
 	for _, invalidM := range []int{0, 2049} {