Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: improve ut cov of clustering compaction task #35242

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Aug 2, 2024

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 2, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby August 2, 2024 10:07
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 2, 2024
@wayblink wayblink force-pushed the ut-improve-2-master branch from ee24167 to 49dd328 Compare August 5, 2024 08:11
@wayblink wayblink force-pushed the ut-improve-2-master branch from 49dd328 to 5b265c3 Compare August 5, 2024 09:52
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.70%. Comparing base (a690370) to head (5b265c3).
Report is 8 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35242      +/-   ##
==========================================
+ Coverage   81.66%   81.70%   +0.04%     
==========================================
  Files        1215     1215              
  Lines      142757   142874     +117     
==========================================
+ Hits       116585   116741     +156     
+ Misses      21762    21713      -49     
- Partials     4410     4420      +10     
Files Coverage Δ
internal/datacoord/compaction_task_clustering.go 79.68% <100.00%> (+12.05%) ⬆️

... and 41 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Aug 5, 2024
@czs007
Copy link
Collaborator

czs007 commented Aug 7, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit c6253f9 into milvus-io:master Aug 7, 2024
15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants