Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance:[cherry-pick] improve ut cov of clustering compaction task #35243

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

wayblink
Copy link
Contributor

@wayblink wayblink commented Aug 2, 2024

issue: #34792
master pr: #35242

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Aug 2, 2024
@sre-ci-robot sre-ci-robot requested review from cydrain and sunby August 2, 2024 10:09
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 2, 2024
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (7f49476) to head (be868a4).
Report is 27 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35243      +/-   ##
==========================================
+ Coverage   72.15%   81.19%   +9.03%     
==========================================
  Files        1052     1052              
  Lines      136987   136991       +4     
==========================================
+ Hits        98847   111224   +12377     
+ Misses      33931    21544   -12387     
- Partials     4209     4223      +14     
Files Coverage Δ
internal/datacoord/compaction_task_clustering.go 79.14% <100.00%> (+12.38%) ⬆️

... and 228 files with indirect coverage changes

Copy link
Contributor

@XuanYang-cn XuanYang-cn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Aug 9, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f7a3fd8 into milvus-io:2.4 Aug 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants