Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: use docker compose instead of docker-compose #35208

Merged
merged 2 commits into from
Aug 2, 2024
Merged

enhance: use docker compose instead of docker-compose #35208

merged 2 commits into from
Aug 2, 2024

Conversation

yellow-shine
Copy link
Collaborator

@yellow-shine yellow-shine commented Aug 2, 2024 •
edited
Loading

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Aug 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 2, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024

@yellow-shine Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024

@yellow-shine E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@yellow-shine yellow-shine force-pushed the docker-compose branch 2 times, most recently from 0e98a57 to 242d88d Compare August 2, 2024 02:48
@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024

@yellow-shine E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Aug 2, 2024

@yellow-shine E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Aug 2, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.53%. Comparing base (a642a26) to head (d4c0cca).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35208      +/-   ##
==========================================
- Coverage   81.54%   81.53%   -0.02%     
==========================================
  Files        1188     1193       +5     
  Lines      142311   142020     -291     
==========================================
- Hits       116047   115791     -256     
+ Misses      21935    21881      -54     
- Partials     4329     4348      +19

see 261 files with indirect coverage changes

This was referenced Aug 2, 2024
Merged
Merged
LoveEachDay
LoveEachDay approved these changes Aug 2, 2024
View reviewed changes
Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LoveEachDay, yellow-shine
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 241c71f into milvus-io:master Aug 2, 2024
15 of 16 checks passed
sre-ci-robot pushed a commit that referenced this pull request Aug 2, 2024
@yellow-shine
enhance: docker-compose first then try to use docker compose (#35227)
3a997e8 
#35209
#35208

---------

Signed-off-by: Yellow Shine <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Aug 2, 2024
@yellow-shine
enhance: docker-compose first then try to use docker compose (#35228)
2df6542 
#35209
#35208

---------

Signed-off-by: Yellow Shine <[email protected]>
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
@yellow-shine @sumitd2
enhance: use docker compose instead of docker-compose (milvus-io#35208)
be48b2c 
milvus-io#35209

---------

Signed-off-by: Yellow Shine <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LoveEachDay LoveEachDay LoveEachDay approved these changes

@congqixia congqixia Awaiting requested review from congqixia

@czs007 czs007 Awaiting requested review from czs007

Assignees

@LoveEachDay LoveEachDay

Labels
area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yellow-shine @sre-ci-robot @LoveEachDay