Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: docker-compose first then try to use docker compose #35227

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

yellow-shine
Copy link
Collaborator

@yellow-shine yellow-shine commented Aug 2, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Aug 2, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Aug 2, 2024
Copy link
Contributor

mergify bot commented Aug 2, 2024

@yellow-shine Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr labels Aug 2, 2024
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Aug 2, 2024
Copy link
Contributor

mergify bot commented Aug 2, 2024

@yellow-shine Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.32%. Comparing base (f8444b9) to head (d335e49).
Report is 4 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35227      +/-   ##
==========================================
- Coverage   80.21%   70.32%   -9.90%     
==========================================
  Files        1052     1052              
  Lines      136848   136848              
==========================================
- Hits       109776    96240   -13536     
- Misses      22858    36386   +13528     
- Partials     4214     4222       +8     

see 260 files with indirect coverage changes

Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: LoveEachDay, yellow-shine
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3a997e8 into milvus-io:2.4 Aug 2, 2024
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants