Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance:[cherry-pick]update mmapchunkmanager config in milvus.yaml #35186

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

cqy123456
Copy link
Contributor

issue: #32984
related pr: #35180

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cqy123456
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Aug 1, 2024
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.13%. Comparing base (f8444b9) to head (f790af9).
Report is 6 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #35186      +/-   ##
==========================================
- Coverage   80.21%   72.13%   -8.09%     
==========================================
  Files        1052     1052              
  Lines      136848   136856       +8     
==========================================
- Hits       109776    98722   -11054     
- Misses      22858    33919   +11061     
- Partials     4214     4215       +1     
Files Coverage Δ
internal/util/initcore/init_core.go 90.14% <ø> (-0.40%) ⬇️

... and 252 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Aug 2, 2024
@czs007 czs007 merged commit d9c1990 into milvus-io:2.4 Aug 2, 2024
12 of 15 checks passed
sre-ci-robot pushed a commit that referenced this pull request Aug 2, 2024
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants