Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance:update mmap_chunk_manager config in milvus.yaml #35180

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

cqy123456
Copy link
Contributor

@cqy123456 cqy123456 commented Aug 1, 2024

issue: #32984
related pr: #35186

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Aug 1, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Aug 1, 2024
Copy link
Contributor

mergify bot commented Aug 1, 2024

@cqy123456 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.25%. Comparing base (095d772) to head (24f011c).
Report is 9 commits behind head on master.

Current head 24f011c differs from pull request most recent head 2ae6b38

Please upload reports for the commit 2ae6b38 to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #35180      +/-   ##
==========================================
+ Coverage   72.23%   72.25%   +0.01%     
==========================================
  Files        1193     1193              
  Lines      142035   141917     -118     
==========================================
- Hits       102600   102543      -57     
+ Misses      35080    35039      -41     
+ Partials     4355     4335      -20     
Files Coverage Δ
internal/util/initcore/init_core.go 90.54% <100.00%> (+0.39%) ⬆️

... and 43 files with indirect coverage changes

@mergify mergify bot added ci-passed and removed ci-passed labels Aug 2, 2024
czs007 pushed a commit that referenced this pull request Aug 2, 2024
@czs007
Copy link
Collaborator

czs007 commented Aug 2, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cqy123456, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b99a554 into milvus-io:master Aug 2, 2024
13 checks passed
sumitd2 pushed a commit to sumitd2/milvus that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants