add a custom http header: Accept-Type-Allow-Int64 #27901

PowderLi · 2023-10-24T14:57:29Z

/kind bug
to #27856
to #27988

mergify · 2023-10-24T14:58:08Z

@PowderLi Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

mergify · 2023-10-24T15:33:17Z

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

mergify · 2023-10-25T02:17:00Z

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2023-10-25T06:31:18Z

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2023-10-25T08:49:41Z

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

PowderLi · 2023-10-25T08:55:52Z

/run-cpu-e2e

codecov · 2023-10-25T09:59:43Z

Codecov Report

Merging #27901 (7e7e323) into master (f93ad64) will increase coverage by 0.01%.
Report is 6 commits behind head on master.
The diff coverage is 76.19%.

@@            Coverage Diff             @@
##           master   #27901      +/-   ##
==========================================
+ Coverage   81.79%   81.81%   +0.01%     
==========================================
  Files         824      820       -4     
  Lines      116574   117054     +480     
==========================================
+ Hits        95353    95764     +411     
- Misses      18061    18121      +60     
- Partials     3160     3169       +9

Files	Coverage Δ
internal/core/src/storage/ChunkCache.cpp	`81.25% <100.00%> (-14.21%)`	⬇️
internal/core/src/storage/ChunkCache.h	`100.00% <ø> (ø)`
internal/distributed/proxy/httpserver/utils.go	`84.78% <100.00%> (+1.14%)`	⬆️
internal/querynodev2/segments/segment.go	`76.24% <100.00%> (+0.49%)`	⬆️
pkg/util/paramtable/http_param.go	`100.00% <100.00%> (ø)`
internal/core/src/storage/MinioChunkManager.cpp	`0.00% <0.00%> (ø)`
internal/distributed/proxy/service.go	`79.77% <62.50%> (-0.20%)`	⬇️
...nternal/distributed/proxy/httpserver/handler_v1.go	`91.70% <82.87%> (-0.35%)`	⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp	`73.53% <26.08%> (-1.73%)`	⬇️

... and 165 files with indirect coverage changes

czs007 · 2023-10-26T06:40:24Z

internal/distributed/proxy/httpserver/utils_test.go

@@ -218,6 +218,11 @@ func generateSearchResult() []map[string]interface{} {
 		FieldBookIntro:          []float32{0.3, 0.33},
 		HTTPReturnDistance:      float32(0.09),
 	}
+	if dataType == schemapb.DataType_String {


cover schemapb.DataType_VarChar

you can modify this in next pr

czs007 · 2023-10-26T06:42:01Z

internal/distributed/proxy/httpserver/handler_v1_test.go

-			StrId: &schemapb.StringArray{
-				Data: []string{"1", "2", "3"},
+		}
+	case schemapb.DataType_String:


cover schemapb.DataType_VarChar

you can modify this in next pr

czs007 · 2023-10-26T06:47:30Z

internal/distributed/proxy/httpserver/handler_v1.go

@@ -404,7 +405,7 @@ func (h *Handlers) query(c *gin.Context) {
 	if err != nil {
 		c.JSON(http.StatusOK, gin.H{HTTPReturnCode: merr.Code(err), HTTPReturnMessage: err.Error()})
 	} else {
-		outputData, err := buildQueryResp(int64(0), response.OutputFields, response.FieldsData, nil, nil)
+		outputData, err := buildQueryResp(int64(0), response.OutputFields, response.FieldsData, nil, nil, strings.ToLower(c.Request.Header.Get(HTTPHeaderAllowInt64)) != "false")


how about strconv.ParseBool ?

czs007 · 2023-10-26T06:49:03Z

internal/distributed/proxy/service.go

+		if val == "" {
+			httpParams := &paramtable.Get().HTTPCfg
+			if !httpParams.AcceptTypeAllowInt64.GetAsBool() {
+				c.Request.Header.Set(httpserver.HTTPHeaderAllowInt64, "false")


do not need to set "true" in case of httpParams.AceptTypeAllocInt64 is true ?

mergify · 2023-10-27T07:54:34Z

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2023-10-27T10:41:01Z

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2023-10-30T05:30:09Z

@PowderLi ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: PowderLi <[email protected]>

mergify · 2023-10-31T02:49:08Z

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

PowderLi · 2023-10-31T02:52:00Z

/run-cpu-e2e

mergify · 2023-10-31T02:54:07Z

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

czs007 · 2023-10-31T07:42:31Z

/approve
/lgtm

sre-ci-robot · 2023-10-31T07:42:43Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~internal/core/OWNERS~~ [czs007]
~~internal/distributed/OWNERS~~ [czs007]
~~pkg/util/OWNERS~~ [czs007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot requested review from bigsheeper and godchen0212 October 24, 2023 14:57

sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Oct 24, 2023

mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-issue labels Oct 24, 2023

PowderLi force-pushed the master-js-int64-drawback branch from f25bf1a to c8f2fff Compare October 25, 2023 02:12

mergify bot removed the do-not-merge/missing-related-issue label Oct 25, 2023

PowderLi force-pushed the master-js-int64-drawback branch from c8f2fff to b526853 Compare October 25, 2023 08:38

czs007 reviewed Oct 26, 2023

View reviewed changes

PowderLi force-pushed the master-js-int64-drawback branch 2 times, most recently from d6a2bd0 to 2fc0d34 Compare October 26, 2023 11:18

mergify bot added the ci-passed label Oct 26, 2023

PowderLi force-pushed the master-js-int64-drawback branch from 2fc0d34 to 3e083ec Compare October 27, 2023 07:10

mergify bot removed the ci-passed label Oct 27, 2023

PowderLi force-pushed the master-js-int64-drawback branch from 3e083ec to 4996cc3 Compare October 27, 2023 10:03

PowderLi force-pushed the master-js-int64-drawback branch from 4996cc3 to 4992ff8 Compare October 30, 2023 05:08

sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Oct 30, 2023

PowderLi force-pushed the master-js-int64-drawback branch 2 times, most recently from 0d082c7 to 8d5d9a1 Compare October 30, 2023 09:02

sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Oct 30, 2023

PowderLi force-pushed the master-js-int64-drawback branch from 8d5d9a1 to bfcc17a Compare October 30, 2023 14:49

add a custom http header: Accept-Type-Allow-Int64

7e7e323

Signed-off-by: PowderLi <[email protected]>

PowderLi force-pushed the master-js-int64-drawback branch from bfcc17a to 7e7e323 Compare October 31, 2023 01:37

sre-ci-robot assigned czs007 Oct 31, 2023

sre-ci-robot added the lgtm label Oct 31, 2023

sre-ci-robot added the approved label Oct 31, 2023

czs007 added the ci-passed label Nov 1, 2023

sre-ci-robot merged commit 0c0f012 into milvus-io:master Nov 1, 2023
11 of 12 checks passed

PowderLi mentioned this pull request Nov 2, 2023

[cherry-pick]add a custom http header: Accept-Type-Allow-Int64 #28125

Merged

PowderLi deleted the master-js-int64-drawback branch November 14, 2023 04:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a custom http header: Accept-Type-Allow-Int64 #27901

add a custom http header: Accept-Type-Allow-Int64 #27901

PowderLi commented Oct 24, 2023 •

edited

Loading

mergify bot commented Oct 24, 2023

mergify bot commented Oct 24, 2023

mergify bot commented Oct 25, 2023

mergify bot commented Oct 25, 2023

mergify bot commented Oct 25, 2023

PowderLi commented Oct 25, 2023

codecov bot commented Oct 25, 2023 •

edited

Loading

czs007 Oct 26, 2023

czs007 Oct 26, 2023

czs007 Oct 26, 2023

czs007 Oct 26, 2023

czs007 Oct 26, 2023

czs007 Oct 26, 2023

mergify bot commented Oct 27, 2023

mergify bot commented Oct 27, 2023

mergify bot commented Oct 30, 2023

mergify bot commented Oct 31, 2023

PowderLi commented Oct 31, 2023

mergify bot commented Oct 31, 2023

czs007 commented Oct 31, 2023

sre-ci-robot commented Oct 31, 2023

add a custom http header: Accept-Type-Allow-Int64 #27901

add a custom http header: Accept-Type-Allow-Int64 #27901

Conversation

PowderLi commented Oct 24, 2023 • edited Loading

mergify bot commented Oct 24, 2023

mergify bot commented Oct 24, 2023

mergify bot commented Oct 25, 2023

mergify bot commented Oct 25, 2023

mergify bot commented Oct 25, 2023

PowderLi commented Oct 25, 2023

codecov bot commented Oct 25, 2023 • edited Loading

Codecov Report

czs007 Oct 26, 2023

Choose a reason for hiding this comment

czs007 Oct 26, 2023

Choose a reason for hiding this comment

czs007 Oct 26, 2023

Choose a reason for hiding this comment

czs007 Oct 26, 2023

Choose a reason for hiding this comment

czs007 Oct 26, 2023

Choose a reason for hiding this comment

czs007 Oct 26, 2023

Choose a reason for hiding this comment

mergify bot commented Oct 27, 2023

mergify bot commented Oct 27, 2023

mergify bot commented Oct 30, 2023

mergify bot commented Oct 31, 2023

PowderLi commented Oct 31, 2023

mergify bot commented Oct 31, 2023

czs007 commented Oct 31, 2023

sre-ci-robot commented Oct 31, 2023

PowderLi commented Oct 24, 2023 •

edited

Loading

codecov bot commented Oct 25, 2023 •

edited

Loading