Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick]add a custom http header: Accept-Type-Allow-Int64 #28125

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

PowderLi
Copy link
Contributor

@PowderLi PowderLi commented Nov 2, 2023

/kind bug
to #27856
to #27988
from #27901

@sre-ci-robot sre-ci-robot added the kind/bug Issues or changes related a bug label Nov 2, 2023
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Nov 2, 2023
Copy link
Contributor

mergify bot commented Nov 2, 2023

@PowderLi Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Nov 2, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Nov 2, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 2, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Nov 2, 2023

/run-cpu-e2e

@PowderLi PowderLi force-pushed the 2.3-js-int64-drawback branch from e5ac198 to 0bebe1d Compare November 2, 2023 23:35
Copy link
Contributor

mergify bot commented Nov 3, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@PowderLi
Copy link
Contributor Author

PowderLi commented Nov 3, 2023

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 3, 2023

@PowderLi E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #28125 (0bebe1d) into 2.3 (02f4d14) will decrease coverage by 0.02%.
Report is 15 commits behind head on 2.3.
The diff coverage is 83.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #28125      +/-   ##
==========================================
- Coverage   81.79%   81.77%   -0.02%     
==========================================
  Files         820      811       -9     
  Lines      116420   116486      +66     
==========================================
+ Hits        95222    95253      +31     
- Misses      18039    18069      +30     
- Partials     3159     3164       +5     
Files Coverage Δ
internal/distributed/proxy/httpserver/utils.go 84.78% <100.00%> (+1.14%) ⬆️
pkg/util/paramtable/http_param.go 100.00% <100.00%> (ø)
internal/core/src/storage/MinioChunkManager.cpp 0.00% <0.00%> (ø)
internal/distributed/proxy/service.go 79.77% <62.50%> (-0.20%) ⬇️
...nternal/distributed/proxy/httpserver/handler_v1.go 91.70% <82.87%> (-0.35%) ⬇️

... and 162 files with indirect coverage changes

@PowderLi
Copy link
Contributor Author

PowderLi commented Nov 3, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 3, 2023
@czs007
Copy link
Collaborator

czs007 commented Nov 6, 2023

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, PowderLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 43db873 into milvus-io:2.3 Nov 6, 2023
12 checks passed
@PowderLi PowderLi deleted the 2.3-js-int64-drawback branch November 14, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants