Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove recollect segment stats during starting datacoord #27410

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Remove recollect segment stats during starting datacoord #27410

merged 1 commit into from
Oct 16, 2023

Conversation

jaime0815
Copy link
Contributor

/kind improvement
recollect segment stats is not essential, removing it will remove dependency Datanode during starting Datacoord.

@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Sep 27, 2023
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Sep 27, 2023
@mergify mergify bot added the dco-passed DCO check passed. label Sep 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Sep 27, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the remove-recollect-segments-during-start-dc branch from b9cf8ff to f0a1982 Compare October 9, 2023 05:48
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

@jaime0815 ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 mentioned this pull request Oct 9, 2023
Merged
@jaime0815 jaime0815 force-pushed the remove-recollect-segments-during-start-dc branch from f0a1982 to b0be37b Compare October 9, 2023 09:28
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the remove-recollect-segments-during-start-dc branch from b0be37b to deb9603 Compare October 9, 2023 09:39
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815 jaime0815 force-pushed the remove-recollect-segments-during-start-dc branch 2 times, most recently from 177f733 to 20beac5 Compare October 9, 2023 12:35
@mergify
Copy link
Contributor

mergify bot commented Oct 9, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #27410 (8351428) into master (bf46ffd) will decrease coverage by 0.06%.
Report is 8 commits behind head on master.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #27410      +/-   ##
==========================================
- Coverage   81.57%   81.51%   -0.06%     
==========================================
  Files         805      805              
  Lines      114315   114243      -72     
==========================================
- Hits        93247    93129     -118     
- Misses      17941    17979      +38     
- Partials     3127     3135       +8
Files Coverage Δ
internal/datacoord/cluster.go 91.89% <ø> (-0.71%) ⬇️
internal/datacoord/server.go 69.01% <ø> (-0.30%) ⬇️
internal/datacoord/session_manager.go 83.98% <ø> (+0.13%) ⬆️
internal/datanode/flow_graph_manager.go 93.10% <ø> (-2.50%) ⬇️
internal/datanode/services.go 81.93% <100.00%> (+0.72%) ⬆️

... and 17 files with indirect coverage changes

@jaime0815 jaime0815 force-pushed the remove-recollect-segments-during-start-dc branch 2 times, most recently from 35d8799 to 0814b24 Compare October 11, 2023 01:57
@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 11, 2023
@jaime0815 jaime0815 force-pushed the remove-recollect-segments-during-start-dc branch from 0814b24 to 62ecb31 Compare October 12, 2023 04:02
@mergify mergify bot removed the ci-passed label Oct 12, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815 jaime0815 force-pushed the remove-recollect-segments-during-start-dc branch from 62ecb31 to 8351428 Compare October 12, 2023 13:14
@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2023

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

3 similar comments
@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Oct 13, 2023
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jaime0815, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e386a62 into milvus-io:master Oct 16, 2023
12 checks passed
@jaime0815 jaime0815 deleted the remove-recollect-segments-during-start-dc branch October 16, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@xiaofan-luan xiaofan-luan

Labels
approved ci-passed dco-passed DCO check passed. kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaime0815 @xiaofan-luan @sre-ci-robot