Remove recollect segment stats during starting datacoord #27562
Conversation
|
@jaime0815 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”) |
|
pr: #27410 |
|
/kind improvement |
sre-ci-robot
added
the
kind/improvement
|
@jaime0815 ut workflow job failed, comment |
|
pr: #27410 |
jaime0815
force-pushed
the
remove-recollect-segments-during-start-dc-22
branch
from
cfd92f4 to
1438a5f
Compare
|
@jaime0815 ut workflow job failed, comment |
Signed-off-by: jaime <[email protected]>
jaime0815
force-pushed
the
remove-recollect-segments-during-start-dc-22
branch
from
1438a5f to
c899bdc
Compare
Codecov Report
@@ Coverage Diff @@
## 2.2.0 #27562 +/- ##
==========================================
- Coverage 80.94% 80.91% -0.04%
==========================================
Files 745 745
Lines 109226 109168 -58
==========================================
- Hits 88416 88335 -81
- Misses 17457 17483 +26
+ Partials 3353 3350 -3
|
|
@jaime0815 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@jaime0815 E2e jenkins job failed, comment |
|
/run-cpu-e2e |
3 similar comments
|
/run-cpu-e2e |
|
/run-cpu-e2e |
|
/run-cpu-e2e |
| func (node *DataNode) ResendSegmentStats(ctx context.Context, req *datapb.ResendSegmentStatsRequest) (*datapb.ResendSegmentStatsResponse, error) { | ||
| log.Info("start resending segment stats, if any", | ||
| zap.Int64("DataNode ID", Params.DataNodeCfg.GetNodeID())) | ||
| segResent := node.flowgraphManager.resendTT() |
There was a problem hiding this comment.
Should we remove the resendTT logic also?
|
/assign @wayblink |
|
@jaime0815 Now we replace segmentStats updates with RPC. Since RPC is synchronous and will cache and resend segmentStats if RPC call failed, so there is no need to Recollect? Is my understanding correct? |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jaime0815, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/kind improvement
cherry pick #27410
pr: #27410